Use direct byte[] utf-8 conversions #136053
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently Elasticsearch is using StandardCharsets#decode and encode methods when working with optimized text. These variants are not as performant as the direct implementations in String when working with byte[]. If we are going to one-shot convert without validation then the String variants should be preferred.
Tim-Brooks
added
>non-issue
:Distributed Indexing/CRUD
|
Pinging @elastic/es-distributed-indexing (Team:Distributed Indexing) |
elasticsearchmachine
added
the
Team:Distributed Indexing
|
I noticed this a few months ago when I was benchmarking something and it seemed to be we should switch variants. I can't think of a scenario where we would prefer the byte buffer encoder variant for String -> bytes. I could see the scenario where we would prefer the byte buffer variant for byte -> String if we wanted to catch UTF-8 errors. However, the default malformed input variant uses replace which is the same as the String ctor variant. public final CharBuffer decode(ByteBuffer bb) {
try {
return ThreadLocalCoders.decoderFor(this)
.onMalformedInput(CodingErrorAction.REPLACE)
.onUnmappableCharacter(CodingErrorAction.REPLACE)
.decode(bb);
} catch (CharacterCodingException x) {
throw new Error(x); // Can't happen
}
}I would note that this is probably different behavior than Jackson would give prior to this change. Are we okay with silently replacing invalid UTF-8 input? @jordan-powers - added the code |
|
jordan-powers
approved these changes
Oct 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently Elasticsearch is using StandardCharsets#decode and encode
methods when working with optimized text. These variants are not as
performant as the direct implementations in String when working with
byte[]. If we are going to one-shot convert without validation then the
String variants should be preferred.